Add more iterable types #2436
Merged
Add more iterable types #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
specify_iterator_types_rest
branch
from
b31d077 to
9184b44
Compare
SenseException
approved these changes
Apr 29, 2022
| * @param array<string, int|string|array<string, string>> $fields | ||
| * @psalm-param SortShape $fields | ||
| * | ||
| * @psalm-return array<string, -1|1|array{"$meta": 'textScore'}> |
There was a problem hiding this comment.
I don't understand how array{"$meta": 'textScore'} fits into the sorting, but it seems the CI is happy with it. Maybe it's worth to put the type into a class and import it?
There was a problem hiding this comment.
👍 I've created a type, the thing here is that I think this is only used for aggregations: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sort/#mongodb-pipeline-pipe.-sort but these methods are used for queries and aggregations.
franmomu
force-pushed
the
specify_iterator_types_rest
branch
from
9184b44 to
94773b1
Compare
franmomu
force-pushed
the
specify_iterator_types_rest
branch
from
94773b1 to
33d4765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #2433
With this finishes adding iterable types in
libdirectory, next PR will add iterable types intestsand will add the PHPStan check.The ignored issues in PHPStan are expected, one is because the type is incorrect and that's what the test is checking (same for Psalm) and the other issues are because PHPStan doesn't yet understand importing custom types in traits.